support scala 3 build for util-test #306
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #304 so that should be merged before this one imo.
There is no Scala 3 compatible version for
"org.scalatestplus" %% "mockito-1-10"
, so I had to use"org.scalatestplus" %% "mockito-3-4" % "3.2.9.0"
. This means I upgraded Scalatest to3.2.9
and Mockito to3.4.x
. This doesn't really break any code inutil-test
but consumers ofutil-test
(e.g.finagle
ortwitter-server
) might also have to upgrade those test dependencies.Since Scala 3 requires Scalatest
3.2.x
and Mockito1.10.x
is ancient at this point, I find this acceptable.The second point is that I couldn't find a direct replacement for
org.mockito.exceptions.Reporter
from Mockito1.10.x
. Since it was only used to throw a predefined exception, I inlined the error message. I hope this is acceptable.